Add additional guards to write_environment_packages.
#75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #71 but adding additional guards to the environment logging (#62). The issue in the stacktrace was that
threw a
json.JSONDecodeErrorbecause the subprocess call failed withSomehow the base conda cannot access the Python package conda that
conda.cliseems to require. I'm not sure how this is possible or exactly what is going on here. But, rather than try and understand the many weird and wondering packaging errors I'm sure we'll encounter, I just extended the try/except clauses to fail gracefully if such an error is encountered. One thing this does not do is log these errors, so it will be difficult to troubleshoot whenfancylogfails to get the environment packages. However, I think this is preferable to including these fancylog-related stacktraces in the logging output?This requires no documentation, but I did not test as I'm not sure the exact environment set up which led to the error. Maybe the person who encountered the error can try fancylog from this branch?