Skip to content

Upgrade and standardize Node.js setup #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Upgrade and standardize Node.js setup #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c497b90
Upgrade @newfold/ui-component-library
desrosj Jul 29, 2025
6afb39f
Upgrade and standardize Node.js setup
desrosj Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint-check-spa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: 16.x
node-version-file: '.nvmrc'
cache: 'npm'

# Checks if node_modules exists in the cache.
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16
22
186 changes: 126 additions & 60 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
"name": "Dave Ryan",
"email": "dave@bluehost.com"
},
"engines": {
"node": ">=22.11.0",
"npm": ">=10.9.0"
},
"devDependencies": {
"@tailwindcss/forms": "^0.5.10",
"@testing-library/cypress": "^10.0.3",
Expand Down Expand Up @@ -37,7 +41,7 @@
"dependencies": {
"@heroicons/react": "^2.2.0",
"@newfold/js-utility-ui-analytics": "^1.4.0",
"@newfold/ui-component-library": "^1.3.0",
"@newfold/ui-component-library": "^2.0.0",
Copy link

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI component library is being upgraded from ^1.3.0 to ^2.0.0, which represents a major version change that could introduce breaking changes. This should be documented in the PR description or tested thoroughly to ensure compatibility.

Copilot uses AI. Check for mistakes.
"@sentry/react": "^9.14.0",
"@wordpress/api-fetch": "^7.17.0",
"@wordpress/data": "^10.17.0",
Expand Down
Loading