feat: Add support for NR ingest-key for integration commands #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 69.86% 70.13% +0.27%
==========================================
Files 20 20
Lines 1858 1882 +24
==========================================
+ Hits 1298 1320 +22
- Misses 560 562 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sashwatdas123
force-pushed
the
Ingest_key
branch
from
18b772b to
d0b7c56
Compare
rittneje
reviewed
Nov 10, 2025
|
|
||
| if input.nr_api_key and input.nr_ingest_key: | ||
| raise click.UsageError( | ||
| "Please provide either the --nr-api-key or the --nr-ingest-key flag, but not both." |
There was a problem hiding this comment.
@Sashwatdas123 It's not clear to me why this is invalid. I need to pass API key to set up account linking, but then it will choose an arbitrary license key. So passing both is perfectly valid.
To that end, maybe instead of this, it should allow specifying the ingest key name, and then the api key is used to find it.
Contributor
Author
There was a problem hiding this comment.
Hi @rittneje , Thank you for sharing this. We are looking into this and will update the PR.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: We have added support for Ingest-Key changes to newrelic-lambda-cli integrations command