Fixed Host normalization for certain cases + support X-Forwarded-Host #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If in System > Config > Web > Add Store Code to URLs is enabled and a custom admin path is set, then Turpentine will not bypass actions in Magento backend. This PR checks, if the option is set to active and extends the answer by adding the code from store id 0, which is the admin backend store view.
Update Abstract.php
admin backends. This is based on the proposed fix by @jdmcd12 in nexcess#937.
This enables the admin backend director when called as /index.php/admin.
This reverts commit a20bf5e.
Fix nexcess#1078 Issue collection nexcess#1180
Fix load balancing for Varnish 4
Update version-3.vcl normalisation
Custom Admin Path with Add Store Code to URLs
Fix for issue nexcess#1093 - poll still displaying when module output disabled
…oved cache hitrate
Condensed the UA "buckets" down to just "mobile" and "other"
Enhanced block logging
Adds and implements an option to log all commands sent to Varnish
nexcess#1213: Generate global blocks like formkey for ESI-Blocks
Allows Custom VCL template
|
Can you please point this PR to devel instead of master and add some more use cases/info so everybody can fully understand this change? |
|
Ok, I'll close this PR first....I think :) |
|
See #1238 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to fixate the Host header for Varnish 4.x. As {{normalize_host}} is included in the VCL file after the first (pass) it may be skipped under certain conditions. This happens for example is you use HTTP authentication, which in return will ensure the wrong Host header will be sent to the backend server. So this should be fixed, see the changes to app/code/community/Nexcessnet/Turpentine/misc/version-4.vcl. Be aware that other versions seem to be fine
The merge request in addition includes the necessary changes to set the Host-Header according to the X-Forwarded-Host-Header some frontend proxy may set. This is the case for Apache for example. This way you can enable host normalization and still allow multisite setups.
(In our case: Apache -> Varnish -> Apache -> Magento)