Fix for custom cookie domain #1415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2017 14:58
The cookie is set by Magento when "Use VLC fix" is set to "Disabled" via config. When a custom cookie domain is configured in Magento, this was not used in the VCL. Then the cookie domain was wrong, which resulted in checkout not working. This commit fixes this problem.
jeroenvermeulen
pushed a commit
to jeroenvermeulen/magento-turpentine
that referenced
this pull request
Jun 22, 2017
…or new visitors. Varnish 4 only yet.
jeroenvermeulen
pushed a commit
to jeroenvermeulen/magento-turpentine
that referenced
this pull request
Jun 22, 2017
…or new visitors. Varnish 4 only yet.
|
Tired of waiting for @nexcess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cookie is set by Magento when "Use VLC fix" is set to "Disabled" via config.
When a custom cookie domain is configured in Magento, this was not used in the VCL.
Then the cookie domain was wrong, which resulted in checkout not working.
This commit fixes this problem.
I made this change for Kega, @itnova