Declarative UI #1836
Open
Declarative UI #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
tobiasKaminsky
force-pushed
the
declarative-ui
branch
from
46595dc to
09cf421
Compare
Contributor
Contributor
tobiasKaminsky
force-pushed
the
declarative-ui
branch
from
e424b9f to
be1621e
Compare
Contributor
2 tasks
tobiasKaminsky
force-pushed
the
declarative-ui
branch
2 times, most recently
from
12510b0 to
373cb73
Compare
Contributor
tobiasKaminsky
force-pushed
the
declarative-ui
branch
from
373cb73 to
c8eff09
Compare
Contributor
alperozturk96
requested changes
Dec 17, 2025
| public void after() { | ||
| removeOnClient(client); | ||
| removeOnClient(client2); | ||
| // removeOnClient(client); |
Contributor
There was a problem hiding this comment.
I guess these are needed for local testing and you need to revert.
|
|
||
| data class App( | ||
| val version: Double, | ||
| @SerializedName("context-menu") |
Contributor
There was a problem hiding this comment.
Why this is not using kotlinx.parcelize.Parcelize as well ?
...ry/src/main/java/com/nextcloud/android/lib/resources/clientintegration/ElementTypeAdapter.kt
Show resolved
Hide resolved
| import com.owncloud.android.lib.resources.OCSRemoteOperation | ||
| import org.apache.commons.httpclient.HttpStatus | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
Small but :)
/**
* Get client integration
*/
No need for this comment. GetClientIntegrationJsonOperation already says same/similar thing. This comment is not explain anything.
library/src/main/java/com/nextcloud/android/lib/resources/clientintegration/Row.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/nextcloud/android/lib/resources/clientintegration/TooltipResponse.kt
Outdated
Show resolved
Hide resolved
alperozturk96
requested changes
Dec 17, 2025
...a/com/nextcloud/android/lib/resources/clientintegration/GetClientIntegrationJsonOperation.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/owncloud/android/lib/resources/status/Method.kt
Show resolved
Hide resolved
Contributor
Contributor
alperozturk96
requested changes
Dec 17, 2025
...y/src/main/java/com/nextcloud/android/lib/resources/clientintegration/ClientIntegrationUI.kt
Outdated
Show resolved
Hide resolved
Contributor
Contributor
Contributor
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
declarative-ui
branch
from
f51ba3b to
1639bf8
Compare
Contributor
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Contributor
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Contributor
Collaborator
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4805-IT-stable-14-14/debug/ |
Collaborator
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4805-IT-master-14-16/debug/ |
alperozturk96
approved these changes
Dec 19, 2025
Collaborator
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4806-IT-stable-14-24/debug/ |
Collaborator
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4806-IT-master-14-27/debug/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.