Skip to content

Conversation

@abhinavohri
Copy link
Contributor

@abhinavohri abhinavohri commented Dec 22, 2025

Resolves: #7780

Summary:
Display alarms in the simple event editor when viewing events in read-only mode.

Before:
image

After:
image

Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>
@SebastianKrupinski
Copy link
Contributor

Hi @abhinavohri

Thank you for the pull request!

Can you post a before and after picture of the changes, so that design can review the changes.

@nimishavijay

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SebastianKrupinski SebastianKrupinski added 3. to review Waiting for reviews design review Issues that were triaged during a design review labels Dec 22, 2025
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nimishavijay
Copy link
Member

Looks good to me for parity with Gcal!

@SebastianKrupinski
Copy link
Contributor

Looks good to me for parity with Gcal!

Perfect, I'll review the code and functionality then.

@SebastianKrupinski
Copy link
Contributor

Tested. Looks good and works

image

@SebastianKrupinski SebastianKrupinski merged commit 0d244bb into nextcloud:main Jan 6, 2026
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design review Issues that were triaged during a design review feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Reminders in Event Card (Optionally?)

3 participants