Skip to content

WIP: Feat/federation #7330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

WIP: Feat/federation #7330

wants to merge 8 commits into from

Conversation

@grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Oct 21, 2025 •
edited
Loading

Checklist for federation features:

  • share board to federated user on trusted instance
  • share board to federated user on any instance (not-trusted)
  • read Board data from incoming federated share
  • add Cards to incoming federated shares
  • update cards on incoming share (description assign user etc)
  • create Stacks on incoming share
  • delete Stacks on incoming share
  • manage board (set color, change name etc.)
  • We should think about if color and name should be per-instance or synced across federated shares
  • reshare incoming federated share
  • update permissions on outgoing federated share
  • Attachments
  • Comments
  • List Activity on incoming federated shares
  • List Activity from federated users correctly
  • Administration settings to restrict federation

@grnd-alt
feat: initiate remote share notifications
6d04f58 
Signed-off-by: grnd-alt <github@belakkaf.net>
@grnd-alt
wip: show federated shares in navigation
fed2c1b 
Signed-off-by: grnd-alt <github@belakkaf.net>
@grnd-alt
read-only federated boards
9e8cecb 
Signed-off-by: grnd-alt <github@belakkaf.net>
juliusknorr
juliusknorr reviewed Oct 29, 2025
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 more comments i had pending while we looked through it in the call

lib/Migration/Version11001Date20251016122010.php Outdated
$schema = $schemaClosure();

$tableName = 'deck_boards_external';
if ($schema->hasTable($tableName)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put all db changes of this pr in one migration file before merging

lib/Service/ExternalBoardService.php
}

public function getExternalBoardFromRemote(Board $localBoard):DataResponse {
$shareToken = $localBoard->getShareToken();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably safeguard that the board has a share token here, as we discussed in the call this is checked before in the controller but should be here as well in case this is used in other places

lib/Service/ExternalBoardService.php
public function getExternalBoardFromRemote(Board $localBoard):DataResponse {
$shareToken = $localBoard->getShareToken();
$participantCloudId = $this->cloudIdManager->getCloudId($this->userId, null);
$ownerCloudId = $this->cloudIdManager->resolveCloudId($localBoard->getOwner());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth to double check the length of the owner column so we can properly fit any federated cloud ids in it

@grnd-alt
feat: federated card creation
8f4866d 
feat: set accessToken from FederationMiddleware
Signed-off-by: grnd-alt <github@belakkaf.net>
@grnd-alt
feat: map external boardIds back to internal ones for frontend
cd298c0 
Signed-off-by: grnd-alt <github@belakkaf.net>
@grnd-alt
fix: remote card creation
a10fcc4 
Signed-off-by: grnd-alt <github@belakkaf.net>
@grnd-alt grnd-alt self-assigned this Oct 30, 2025
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Oct 30, 2025
@grnd-alt grnd-alt moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Oct 30, 2025
@grnd-alt
feat: create stacks on remote share
f721f5e 
Signed-off-by: grnd-alt <github@belakkaf.net>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 83373 was 82774 (+0.72%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt
feat: delete stacks on remote shares
fcae61d 
Signed-off-by: grnd-alt <github@belakkaf.net>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 83371 was 82774 (+0.72%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud will be requested when the pull request is marked ready for review luka-nextcloud is a code owner

@elzody elzody Awaiting requested review from elzody elzody will be requested when the pull request is marked ready for review elzody is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@grnd-alt grnd-alt

Labels

None yet

Projects

📝 Office team
Status: 🏗️ In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grnd-alt @juliusknorr