Skip to content

Conversation

@DrummyFloyd
Copy link
Contributor

Description of the change

Add httpRoute kind, because is the new sucesso of ingress and is now GA

Benefits

better control , and new standard

Checklist

@DrummyFloyd DrummyFloyd requested a review from wrenix December 5, 2025 08:29
@wrenix
Copy link
Collaborator

wrenix commented Dec 5, 2025

The format of httpRoute values.yaml is different when using helm create <chartname. we should be align with it.
So please rename http to httpRoute.

also drop filters, matches and additionalRules for just rules.

here the templates

{{- if .Values.httpRoute.enabled -}}
{{- $fullName := include "nextcloud.fullname" . -}}
{{- $svcPort := .Values.service.port -}}
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: {{ $fullName }}
  labels:
    {{- include "nextcloud.labels" . | nindent 4 }}
  {{- with .Values.httpRoute.annotations }}
  annotations:
    {{- toYaml . | nindent 4 }}
  {{- end }}
spec:
  parentRefs:
    {{- with .Values.httpRoute.parentRefs }}
      {{- toYaml . | nindent 4 }}
    {{- end }}
  {{- with .Values.httpRoute.hostnames }}
  hostnames:
    {{- toYaml . | nindent 4 }}
  {{- end }}
  rules:
    {{- range .Values.httpRoute.rules }}
    {{- with .matches }}
    - matches:
      {{- toYaml . | nindent 8 }}
    {{- end }}
    {{- with .filters }}
      filters:
      {{- toYaml . | nindent 8 }}
    {{- end }}
      backendRefs:
        - name: {{ $fullName }}
          port: {{ $svcPort }}
          weight: 1
    {{- end }}
{{- end }}

DrummyFloyd and others added 4 commits December 5, 2025 10:45
Signed-off-by: DrummyFloyd <jonathan.monnet28@gmail.com>
Signed-off-by: DrummyFloyd <jonathan.monnet28@gmail.com>
Co-authored-by: WrenIX <133280015+wrenix@users.noreply.github.com>
Signed-off-by: DrummyFloyd <jonathan.monnet28@gmail.com>
Signed-off-by: DrummyFloyd <jonathan.monnet28@gmail.com>
@DrummyFloyd
Copy link
Contributor Author

DrummyFloyd commented Dec 5, 2025

The format of httpRoute values.yaml is different when using helm create <chartname. we should be align with it. So please rename http to httpRoute.

also drop filters, matches and additionalRules for just rules.

here the templates

{{- if .Values.httpRoute.enabled -}}
{{- $fullName := include "nextcloud.fullname" . -}}
{{- $svcPort := .Values.service.port -}}
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: {{ $fullName }}
  labels:
    {{- include "nextcloud.labels" . | nindent 4 }}
  {{- with .Values.httpRoute.annotations }}
  annotations:
    {{- toYaml . | nindent 4 }}
  {{- end }}
spec:
  parentRefs:
    {{- with .Values.httpRoute.parentRefs }}
      {{- toYaml . | nindent 4 }}
    {{- end }}
  {{- with .Values.httpRoute.hostnames }}
  hostnames:
    {{- toYaml . | nindent 4 }}
  {{- end }}
  rules:
    {{- range .Values.httpRoute.rules }}
    {{- with .matches }}
    - matches:
      {{- toYaml . | nindent 8 }}
    {{- end }}
    {{- with .filters }}
      filters:
      {{- toYaml . | nindent 8 }}
    {{- end }}
      backendRefs:
        - name: {{ $fullName }}
          port: {{ $svcPort }}
          weight: 1
    {{- end }}
{{- end }}

should be good, now, but can you check on your side, because i have a strange behaviour .. on my end (must be related to my helm (CLI) latest update

Error: template: nextcloud/templates/_helpers.tpl:14:14: executing "nextcloud.fullname" at <.Values.fullnameOverride>: nil pointer evaluating interface {}.fullnameOverride

Signed-off-by: DrummyFloyd <jonathan.monnet28@gmail.com>
@wrenix
Copy link
Collaborator

wrenix commented Dec 11, 2025

Sorry for the long delay. I have not find any time on the weekend to test your code.

@DrummyFloyd
Copy link
Contributor Author

Sorry for the long delay. I have not find any time on the weekend to test your code.

don't worry ^^
meanwhile i use a plain manifest for my need =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants