Skip to content

Conversation

@SwikritiT
Copy link
Contributor

This pr removes the id attribute from the input field, which will make it easier for the e2e tests #265 to get better selectors

Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
@github-actions
Copy link

JS Code Coverage

Coverage after merging remove-id-from-textinput into master will be
93.71%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   bootstrap.js0%0%0%0%1, 1–7
   dashboard.js0%0%0%0%1, 1, 10–19, 2, 20–27, 3–9
   fileActions.js0%0%0%0%1, 1, 10–17, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2, 20–25, 3–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–66, 7–9
   utils.js57.45%33.33%50%59.52%10–14, 17–26, 6–9
src/components
   AdminSettings.vue99.09%95.83%77.78%99.86%1, 1, 1
   OAuthConnectButton.vue99.08%80%100%100%1
   PersonalSettings.vue97.81%91.67%71.43%99.39%1, 1
src/components/admin
   FieldValue.vue95.56%62.50%100%98.77%1, 1, 1, 1
   FormHeading.vue98.98%75%100%100%1
   TextInput.vue98.50%80%87.50%100%1, 1, 1
src/components/icons
   ClippyIcon.vue93.18%50%50%97.50%1, 1
src/components/settings
   CheckBox.vue92.45%80%66.67%97.62%1, 1
   SettingsTitle.vue94.74%50%100%97.14%1, 1
src/components/tab
   EmptyContent.vue99.34%90.91%100%100%1
   SearchInput.vue99.56%83.33%100%100%1
   WorkPackage.vue99.01%33.33%100%99.66%1, 1, 1
src/utils
   workpackageHelper.js97.46%96%100%97.75%17–19
src/views
   Dashboard.vue98.20%50%50%99.63%1, 1, 1
   ProjectsTab.vue99.74%92.31%100%100%23

@github-actions
Copy link

PHP Code Coverage

Coverage after merging remove-id-from-textinput into master will be
63.26%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
lib/AppInfo
   Application.php20.69%100%25%20%106, 110, 61–62, 65, 72, 74–76, 81–84, 86, 90–95
lib/BackgroundJob
   CheckNotifications.php0%100%0%0%48, 50, 52–53, 61–62
lib/Controller
   ConfigController.php79.43%100%66.67%80.30%111–112, 114, 116–118, 120, 126–127, 129, 319–322, 324–325, 328, 336–340, 362–364, 94
   DirectDownloadController.php0%100%0%0%36–38, 53–55, 57, 60–61
   FilesController.php73.68%100%100%71.91%168, 221–222, 267, 273–277, 281–282, 285, 287, 298–300, 303–304, 306–307, 311–314, 317
   OpenProjectAPIController.php84.92%100%78.57%85.41%136, 171, 188–189, 193, 197, 199–204, 206, 215–216, 219, 221, 223–226, 228–229, 234, 253, 278, 95
lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101–102, 104–108, 116, 123–124, 126, 128–129, 131–132, 134, 137–138, 140–141, 143, 69–73, 80, 87, 94
lib/Exception
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
lib/Listener
   LoadSidebarScript.php0%100%0%0%100–101, 103–104, 106, 108, 65–70, 72–73, 75–76, 78–79, 85–86, 88, 90, 92–94, 96, 98
lib/Notification
   Notifier.php0%100%0%0%101, 103–106, 109–110, 113, 120–122, 124–125, 127–128, 130, 132–135, 141–142, 144, 146, 155–156, 158–159, 164–168, 61–66, 76, 85, 96, 98
lib/Search
   OpenProjectSearchProvider.php0%100%0%0%102, 109–110, 113–116, 118–119, 123–125, 127–128, 130–131, 133–135, 138–139, 141–142, 146–147, 149–151, 157–158, 160, 169, 177–183, 192–197, 206, 71–75, 82, 89, 97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
lib/Service
   DirectDownloadService.php88%100%100%86.96%65–66, 68
   OauthService.php0%100%0%0%101–105, 115–118, 42–44, 53–59, 61, 70–73, 84–91
   OpenProjectAPIService.php86.97%100%88.46%86.84%148, 175, 203, 233–237, 266–270, 433–434, 436, 450–451, 460, 464, 485, 573–574, 581, 584–587, 589, 595, 599–601, 773, 844, 874–875, 877, 879–880
lib/Settings
   Admin.php0%100%0%0%32–34, 41–43, 46–50, 53, 58–60, 63, 65–66, 68, 72, 76
   AdminSection.php0%100%0%0%19–20, 29, 39, 48, 55
   Personal.php88.89%100%50%93.75%101, 105
   PersonalSection.php0%100%0%0%19–20, 29, 39, 48, 55

@SwikritiT SwikritiT merged commit 75bfe88 into master Nov 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-id-from-textinput branch November 23, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants