Feature/54562/drop mounts on full or provider setup #57289
Merged
+186
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
changed the base branch from
master
to
feature/54562/support-partial-share-providers
salmart-dev
force-pushed
the
feature/54562/drop-mounts-on-full-or-provider-setup
branch
from
9503239 to
239647d
Compare
8 tasks
salmart-dev
force-pushed
the
feature/54562/support-partial-share-providers
branch
from
147446b to
a449af6
Compare
salmart-dev
force-pushed
the
feature/54562/drop-mounts-on-full-or-provider-setup
branch
from
239647d to
463f8cd
Compare
salmart-dev
changed the base branch from
feature/54562/support-partial-share-providers
to
master
salmart-dev
force-pushed
the
feature/54562/drop-mounts-on-full-or-provider-setup
branch
from
463f8cd to
5de8e11
Compare
salmart-dev
requested review from
Altahrim,
leftybournes,
provokateurin and
yemkareems
and removed request for
a team
CarlSchwan
approved these changes
Jan 6, 2026
artonge
force-pushed
the
feature/54562/drop-mounts-on-full-or-provider-setup
branch
from
5de8e11 to
6a7f493
Compare
artonge
approved these changes
Jan 6, 2026
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Renamed $userMount to $isUserMount, but looks good otherwise.
artonge
force-pushed
the
feature/54562/drop-mounts-on-full-or-provider-setup
branch
from
6a7f493 to
d8d172c
Compare
Open
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
artonge
force-pushed
the
feature/54562/drop-mounts-on-full-or-provider-setup
branch
from
d8d172c to
2d22c4f
Compare
artonge
added
feature: filesystem
php
artonge
deleted the
feature/54562/drop-mounts-on-full-or-provider-setup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes mounts from the
MountManagerif they were setup by path with partial mount providers (implementing IPartialMountProvider) and a full user setup or provider setup is triggered afterwards.This prevents setting up mounts multiple times and duplicated mount objects when using partial mount providers in combination with full-provider setup.
TODO
Checklist
3. to review, feature component)stable32)