fix(settings): Improve sharing form labels

[castillo92]

Summary

If you visit Settings -> Administration -> Sharing you can see 3 options and I think the text could be improved because, in short, the title and options are:

"Limit sharing based on groups:"

• Allow all
• Exclude some groups
• Allow only some groups

And if you select any option, the textbox explain itself:

Line 133 :label="settings.excludeGroups === 'allow' ? t('settings', 'Groups allowed to share') : t('settings', 'Groups excluded from sharing')"

Therefore, I believe that text labels could be simplified.

TODO

• Agree to my proposal and change text label.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes

BEFORE:

• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[artonge]

@castillo92 can you update your commit to respect the conventional commit specification? :)
Something like: fix(settings): Improve sharing form labels

[castillo92]

@castillo92 can you update your commit to respect the conventional commit specification? :) Something like: fix(settings): Improve sharing form labels

You're absolutely right, I did it just as you suggested. I'm new to this.

[artonge]

You're absolutely right, I did it just as you suggested. I'm new to this.

Looks like you updated the pull request title, but not the commit message. You'll have to amend it and then to force push it. Those commands should do it:

git commit --amend # This will open an editor, then you can change the message accordingly
git push --force-with-lease # This will override the commit that you already pushed

[castillo92]

You're absolutely right, I did it just as you suggested. I'm new to this.

Looks like you updated the pull request title, but not the commit message. You'll have to amend it and then to force push it. Those commands should do it:

git commit --amend # This will open an editor, then you can change the message accordingly
git push --force-with-lease # This will override the commit that you already pushed

Thanks for the clarification. I should mention that I’m a hobbyist contributor and I’m currently working through GitHub’s web interface, which doesn’t allow amending commit messages or force-pushing. Unfortunately, that makes it impossible for me to update the existing commit message from my side.

Please let me know if a follow-up commit with a conventional message would be acceptable.