Message Pinning 📌

[rapterjet2004]

The CI/CD Analysis check seems to be broken

• fixes Implement Message Pinning 📌 #5534

🚧 TODO

• Shared Items support
• Fixed hiding messages
• Fix moderation
• Fix timestamp
• UI suggestions
• pinned mentions don't work

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

@rapterjet2004 as there is a chance that checks succeed now, can you rebase? Might be there will some merge conflicts..

[mahibi]

just rejecting for now to not merge before a potential v22.1.0 branchoff...

[mahibi]

• Showing the details (the "Pinned until..." bubble) should be changed in my opinion.

• It has the same bubble color as the own message have. It's a bit confusing in my opinion.

• It does not need to be shown permanently.

• The bubble doesn't seem to catch tap events. When clicking on it, the underlying chat view is clicked (Noticed it when collapse/uncollapse was triggered in background)

• I think the buttons to hide and unpin are very tiny

• I would expect a menu when long clicking the pinned message (see iOS implementation: nextcloud/talk-ios#2262)

• Go to message is not implemented? The chat should scroll the the message when the pinned message is clicked.

• Pinned messages should be added as a new type to "shared items"

• In 1:1 conversations only possible to pin own message. But i can unpin a message from other participant. Please align how the behavior should be in 1:1 chats with other clients

• If not being a moderator i see pinned messages and the "hide" button, but i can not hide. Please align with other clients

• Somehow i got "Error in pinMessage: retrofit2.HttpException: HTTP 403"
  but i can't reproduce...
  I think i was not a moderator but saw the pin message option somehow.

[sowjanyakch]

• The messages from the moderators cannot be pinned. I would expect to pin the messages from the moderators also.
• When a message is pinned, I see two buttons hide and unpin - the UI is little confusing and clicking on both hide and unpin buttons shows the same system message "You unpinned a message". Looks like hide button is also performing unpin action.
• Pinned until .... is showing wrong time. Pin a message and set custom time pin until 6:00 PM and see the message and it shows wrong time.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5535.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	99	100
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	54	54
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	81	81

Lint increased!