WIP receive chat message from HPB #5635
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahibi
force-pushed
the
feature/5633/chatRelay
branch
2 times, most recently
from
074dc73 to
2d34ff3
Compare
mahibi
force-pushed
the
feature/5633/chatRelay
branch
from
2d34ff3 to
ab134d2
Compare
for now, directly passed to ChatActivity and just log it without further processing Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
known issues: mark chat as read not working (have to use separate endpoint to mark as read) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
wip: Maybe trigger it when the user scrolled to the bottom on his own. E.g. when a scrolling listener tells "scrolling is finished" we check if it's scrolled to the bottom and then send the mark as read also todo: mark as read "when the user is sending the app to the background or navigates "back to conversation list" and the last message a user read (saw on screen) is a higher id then the previous known readmarker" Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
known issues: does not work well together with val weHaveAtLeastTheLastReadMessage = newestMessageIdFromDb >= conversationModel.lastReadMessage.toLong() for now. (Messages can be missing on initial load) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
feature/5633/chatRelay
branch
from
ab134d2 to
3127450
Compare
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5635.apk |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #5633
WIP
TODO
🏁 Checklist
/backport to stable-xx.x