Skip to content

Workflow onComplete and onError sections #6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2025

Conversation

bentsherman
Copy link
Member

This PR adds new syntax for workflow onComplete and onError as sections in the entry workflow instead of closure calls.

It also deprecates config workflow handlers, as this kind of code should be implemented in a plugin trace observer. This is better anyway since a plugin is easier to re-use across multiple pipelines.

@bentsherman bentsherman added this to the 25.10 milestone Jul 15, 2025
@bentsherman bentsherman requested a review from pditommaso July 15, 2025 00:33
@bentsherman bentsherman requested review from a team as code owners July 15, 2025 00:33
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit a28300f
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/6893629d3abe29000800d05c
😎 Deploy Preview https://deploy-preview-6275--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bentsherman bentsherman marked this pull request as draft July 15, 2025 02:04
@bentsherman bentsherman force-pushed the workflow-oncomplete-onerror branch from 56f1d5a to 51e33e5 Compare July 15, 2025 13:38
@bentsherman bentsherman marked this pull request as ready for review July 15, 2025 13:58
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman force-pushed the workflow-oncomplete-onerror branch from 51e33e5 to d532bb1 Compare July 15, 2025 16:39
Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions for the docs.

Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion for a missing word. Otherwise looks great. Non-blocking so approved.

bentsherman and others added 2 commits August 6, 2025 08:34
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman merged commit 4fd97b9 into master Aug 6, 2025
19 of 23 checks passed
@bentsherman bentsherman deleted the workflow-oncomplete-onerror branch August 6, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants