-
Notifications
You must be signed in to change notification settings - Fork 717
Workflow onComplete and onError sections #6275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
56f1d5a
to
51e33e5
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
51e33e5
to
d532bb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions for the docs.
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io> Signed-off-by: Ben Sherman <bentshermann@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion for a missing word. Otherwise looks great. Non-blocking so approved.
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io> Signed-off-by: Ben Sherman <bentshermann@gmail.com>
This PR adds new syntax for workflow onComplete and onError as sections in the entry workflow instead of closure calls.
It also deprecates config workflow handlers, as this kind of code should be implemented in a plugin trace observer. This is better anyway since a plugin is easier to re-use across multiple pipelines.