Type checking support #6482
Open
Type checking support #6482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
bentsherman
force-pushed
the
type-checking-utils
branch
from
6a7d8a1 to
2c2168f
Compare
jorgee
reviewed
Oct 20, 2025
| return true; | ||
| var type = genericsType.getType(); | ||
| resolveOrFail(type, genericsType); | ||
| resolve(type); |
There was a problem hiding this comment.
Why is the failure removed? Also ignoring the return. Not understanding this part.
There was a problem hiding this comment.
It was causing an unhelpful error when a generic type argument couldn't be resolved. But now I remember I need to propagate this error up the stack and still report it, so I will add that
jorgee
reviewed
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few things to nf-lang to help enable type checking in the language server.
The full type checker will eventually be incorporated into nf-lang, but for now it will reside in the language server while we continue to develop it. This way I can release improvements to the type checker without requiring a Nextflow patch release
No unit tests because these changes are covered by language server unit tests for now.
Summary of changes:
Save method overloads in
VariableScopeVisitorwhen a method call matches multiple possible methods (used by type checker to select method or provide appropriate error message)Add
@NamedParamsannotation to standard library functions (used by type checker to validate named params)Fix resolution of output types for processes and workflows
Resolve
paramsblock during name checking (was previously done only by language server)Minor bug fixes