Skip to content

Conversation

@bentsherman
Copy link
Member

Follow-up to #6361

Refactors config classes and packages to use "spec" instead of "schema", since "schema" now refers to the schema of a plugin spec

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested review from a team as code owners October 14, 2025 17:18
@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit fed70a7
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68efa38089654c0008b2bcaf
😎 Deploy Preview https://deploy-preview-6485--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@christopher-hakkaart christopher-hakkaart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good. One suggestion to make the section title sentence case.

bentsherman and others added 2 commits October 15, 2025 08:36
Co-authored-by: Chris Hakkaart <chris.hakkaart@seqera.io>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman merged commit ef0d2d6 into master Oct 15, 2025
24 checks passed
@bentsherman bentsherman deleted the refactor-config-schema-to-spec branch October 15, 2025 15:50
pditommaso added a commit that referenced this pull request Oct 20, 2025
…es (#6495)

This commit addresses two issues stemming from the recent config.schema
to config.spec package rename in #6485:

1. End-to-End Test Infrastructure Fix
    - Fixed test-e2e/run.sh to use the proper `installScratch` Makefile target
    - Changed from separate `make assemble` + `make install` to combined
      `make releaseInfo assemble installScratch`
    - The `installScratch` target (BUILD_PACK=1) is specifically designed for
      creating scratch container images used in the e2e test pipeline
    - This ensures the Nextflow runtime is correctly prepared for containerization
      and deployment to the Seqera Platform test environments

2. Backward Compatibility
    - Added deprecated type aliases in the old `nextflow.config.schema` package
    - Prevents `NoClassDefFoundError: nextflow/config/schema/ConfigScope` when
      loading plugins compiled against older Nextflow versions
    - Added deprecated classes: ConfigScope, ConfigOption, ScopeName, PlaceholderName
    - All deprecated classes delegate to their new counterparts in config.spec
    - Includes @deprecated annotations with Javadoc pointing to new locations

The e2e test fixes ensure that the automated testing pipeline against Seqera
Platform staging and production environments works correctly, while the
compatibility aliases give plugin developers time to migrate to the new
package structure.

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso added a commit that referenced this pull request Oct 21, 2025
…es (#6495)

This commit addresses two issues stemming from the recent config.schema
to config.spec package rename in #6485:

1. End-to-End Test Infrastructure Fix
    - Fixed test-e2e/run.sh to use the proper `installScratch` Makefile target
    - Changed from separate `make assemble` + `make install` to combined
      `make releaseInfo assemble installScratch`
    - The `installScratch` target (BUILD_PACK=1) is specifically designed for
      creating scratch container images used in the e2e test pipeline
    - This ensures the Nextflow runtime is correctly prepared for containerization
      and deployment to the Seqera Platform test environments

2. Backward Compatibility
    - Added deprecated type aliases in the old `nextflow.config.schema` package
    - Prevents `NoClassDefFoundError: nextflow/config/schema/ConfigScope` when
      loading plugins compiled against older Nextflow versions
    - Added deprecated classes: ConfigScope, ConfigOption, ScopeName, PlaceholderName
    - All deprecated classes delegate to their new counterparts in config.spec
    - Includes @deprecated annotations with Javadoc pointing to new locations

The e2e test fixes ensure that the automated testing pipeline against Seqera
Platform staging and production environments works correctly, while the
compatibility aliases give plugin developers time to migrate to the new
package structure.

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants