Skip to content

Nmc/1924 Sharing customizations #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
surinder-tsys wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Nmc/1924 Sharing customizations #75

surinder-tsys wants to merge 1 commit into from

Conversation

@surinder-tsys
Copy link

@surinder-tsys surinder-tsys commented May 5, 2023 •
edited
Loading

This PR contains the following:

  1. Different icons for shared, share-received.
  2. Using only Internal, External and Link shares.
  3. Different permissions for Link, Internal and external shares based on the type of file and folders.
  4. Displaying folder/file(preview) icon on FileDetailFragment.
  5. Share suggestion list customization.
  6. Removed comments tab, so no ViewPager is used.
  7. Showing shared labels in landscape mode and tablet device on file listview.

NMC-3599 --> New Sharing UI updated.

@surinder-tsys surinder-tsys added the custom MagentaCLOUD customisation label May 5, 2023
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 2 times, most recently from 67d617f to 688d6b0 Compare May 16, 2023 07:40
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 5 times, most recently from 4df1599 to e21f356 Compare May 19, 2023 11:36
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from 72ed229 to 4fa6146 Compare May 30, 2023 10:48
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 4 times, most recently from afa1569 to 3f22acb Compare June 15, 2023 09:26
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from 4951f39 to d1db895 Compare June 27, 2023 18:20
@surinder-tsys
Copy link
Author

surinder-tsys commented Jul 5, 2023

Rebase or remove the download limit code once both upstreamed PR is merged by NC:

  1. Download limit for file link share nextcloud/android#11563
  2. Download limit for file link share nextcloud/android-library#1123

@surinder-tsys surinder-tsys changed the title Nmc/1924 sharing Nmc/1924 Sharing customizations Jul 13, 2023
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from b223c14 to 5bb632c Compare July 25, 2025 07:50
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 4 times, most recently from f81c1d0 to b610ef8 Compare August 13, 2025 07:16
@github-actions github-actions bot mentioned this pull request Aug 26, 2025
Closed
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 6 times, most recently from 1fb9229 to 113f5cd Compare September 4, 2025 13:23
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 2 times, most recently from 72693d8 to 982cdb1 Compare September 12, 2025 07:23
@github-actions github-actions bot mentioned this pull request Sep 23, 2025
Closed
@surinder-tsys surinder-tsys force-pushed the nmc/1924-sharing branch 3 times, most recently from ec2ea93 to 71c7050 Compare December 8, 2025 07:29
@github-actions github-actions bot mentioned this pull request Dec 8, 2025
Open
@surinder-tsys
Customizations done for Sharing with test cases.
2f854b2 
Download limit functionality added.
Email selection from contact implemented with Test Cases.
Share new ui updated with divider, index icons, colors, empty state.
Received sharing disabled state handled.
Test cases updated
Updated colors as per NMC-4218
NMC-3928 fix: avoid resetting download counter on every update of advance permission
NMC-4653: clear edittext focus on action done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

approved build-ready Customization to include into build custom MagentaCLOUD customisation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@surinder-tsys