Skip to content

[CI/CD] Various fixes #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2025
Merged

[CI/CD] Various fixes #1200

merged 4 commits into from
Aug 11, 2025

Conversation

sean-breen
Copy link
Contributor

@sean-breen sean-breen commented Aug 7, 2025

Proposed changes

Includes some CI/CD fixes:

  • Adds a new job sanity-check which will run a build using the Development Go module repository as a GOPROXY. This willl not run on forked repos, and is used to check that all our dependencies are in place for builds which use this proxy.

  • Fetch tags during code checkouts to allow for correct versioning when building locally

  • Sets the Version check in Makefile to mimic the v2 logic, first check the git describe output, and if not present then pull the latest tag and set it to that (v3.2.0 at time of writing)

  • Re-enables the performance test benchmark results being posted to the benchmark-results branch for observation. This was being run in the pipeline but hasn't been updated since the branch switchover.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@github-actions github-actions bot added the bug Something isn't working label Aug 7, 2025
@sean-breen sean-breen marked this pull request as ready for review August 8, 2025 09:51
@sean-breen sean-breen requested a review from a team as a code owner August 8, 2025 09:51
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Aug 8, 2025
Comment on lines 26 to 27
sanity-check:
name: Sanity Check
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sanity-check:
name: Sanity Check
goproxy-sanity-check:
name: GOPROXY Sanity Check

@sean-breen sean-breen merged commit ba88e4c into main Aug 11, 2025
13 checks passed
@sean-breen sean-breen deleted the ci-fixes branch August 11, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants