Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Includes some CI/CD fixes:
Adds a new job
sanity-check
which will run a build using the Development Go module repository as aGOPROXY
. This willl not run on forked repos, and is used to check that all our dependencies are in place for builds which use this proxy.Fetch tags during code checkouts to allow for correct versioning when building locally
Sets the Version check in
Makefile
to mimic thev2
logic, first check thegit describe
output, and if not present then pull the latest tag and set it to that (v3.2.0
at time of writing)Re-enables the performance test benchmark results being posted to the
benchmark-results
branch for observation. This was being run in the pipeline but hasn't been updated since the branch switchover.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)