Skip to content

Conversation

sean-breen
Copy link
Contributor

@sean-breen sean-breen commented Oct 21, 2025

Proposed changes

Adds a new GitHub Action configure-goproxy which can determine which value to use for GOPROXY environment variable. If secrets are available it will use the one from Artifactory. If not it will use direct. This should allow both dependabot and forked branches to use the direct proxy when secrets are not available.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.00%. Comparing base (b198c00) to head (1c78f8e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   84.88%   85.00%   +0.11%     
==========================================
  Files         100      100              
  Lines       14528    14528              
==========================================
+ Hits        12332    12349      +17     
+ Misses       1735     1716      -19     
- Partials      461      463       +2     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b198c00...1c78f8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sean-breen sean-breen marked this pull request as ready for review October 22, 2025 14:40
@sean-breen sean-breen requested a review from a team as a code owner October 22, 2025 14:40
@Akshay2191 Akshay2191 self-requested a review October 23, 2025 10:41
@sean-breen sean-breen merged commit 3bee777 into main Oct 23, 2025
39 checks passed
@sean-breen sean-breen deleted the conditional-goproxy branch October 23, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants