chore: update golang versions #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a broken build by upgrading to the latest golang version. Also updated `gomarkdown` to resolve some low-priority security notices and `golangci-lint` to keep up with the golang version. The build broke because we're using "latest" versions of some dev libraries. I considered pinning those instead of upgrading golang, but "latest" fails infrequently, and we're already two minor versions behind on golang so needed to update anyway. If we have a similar failure will switch to a `tools.go` approach and manage tool versions in go.mod with the rest of the dependencies. fixes #307
4141done
approved these changes
Dec 18, 2024
4141done
left a comment
4141done
left a comment
There was a problem hiding this comment.
Thank you for unsticking the build 🐳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix a broken build by upgrading to the latest golang version.
Also updated
gomarkdownto resolve some low-priority security notices andgolangci-lintto keep up with the golang version.The build broke because we're using "latest" versions of some dev libraries. I considered pinning those instead of upgrading golang, but "latest" fails infrequently, and we're already two minor versions behind on golang so needed to update anyway.
If we have a similar failure will switch to a
tools.goapproach and manage tool versions in go.mod with the rest of the dependencies.fixes #307
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)