Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/nodejs/unit-http/http_server.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ ServerResponse.prototype._removeHeader = function _removeHeader(lc_name) {
this.headers_count -= value.length;
this.headers_len -= value.length * name_len;

value.forEach(function(val) {
this.headers_len -= Buffer.byteLength(val + "", 'latin1');
});
for (let i = 0; i < value.length; i++){
this.headers_len -= Buffer.byteLength(value[i] + "", 'latin1');
}

return;
}
Expand Down
6 changes: 6 additions & 0 deletions test/node/set_header_array_with_override/app.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

require('http').createServer(function (req, res) {
res.setHeader('Set-Cookie', ['tc=one,two,three', 'tc=four,five,six']);
res.setHeader('Set-Cookie', ['tc=one,two,three', 'tc=four,five,six', 'tc=seven,eight,nine']);
res.end();
}).listen(8080);
10 changes: 10 additions & 0 deletions test/test_node_application.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,16 @@ def test_node_application_set_header_array():
], 'set header array'


def test_node_application_set_header_array_with_override():
client.load('set_header_array_with_override')

assert client.get()['headers']['Set-Cookie'] == [
'tc=one,two,three',
'tc=four,five,six',
'tc=seven,eight,nine',
], 'set header array with override'


@pytest.mark.skip('not yet')
def test_node_application_status_message():
client.load('status_message')
Expand Down
Loading