Skip to content

Conversation

@alirezamirian
Copy link

@alirezamirian alirezamirian commented Mar 6, 2019

cookieService.remove calls cookieService.put with the value of undefined.
When the value is undefined (or null), response.clearCookie should be used.
Alternatively, we could call response.cookie with proper expiry option and an empty string value, but this is already done in clearCookie method of express response object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant