Support angular 10 #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenkeiras
added a commit
to programaker-project/Programaker-Core
that referenced
this pull request
Nov 2, 2020
This will be used to store authentication data. The reason for this is to make this data available to the server during the SSR so it can be used to render values that come from API queries. This uses temporarily a fork of @ngx-utils/cookies, while the support needed for Angular 10 is not merged. The associated PR for this support is ngx-utils/cookies#24.
|
Hi, I have a question. Will this branch be merged soon? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all, thanks for the great library, it is really useful.
This PR applies the migration described on ModuleWithProviders Migration so the library build's successfully on Angular 10. This should be backwards compatible from Angular 7.
I've separated the commit that changes the package-lock.json in case it's preferable to not update it until a package release is made.