Skip to content

Conversation

night-crawler
Copy link
Owner

No description provided.

@night-crawler night-crawler requested a review from Copilot May 24, 2025 14:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the library and its tests to use jsonpath-rust v1.0.2, pyo3 v0.25, and pythonize v0.25.
Key changes:

  • Bump crate and dependency versions to 1.0.2 and migrate to the new jsonpath-rust API in src/lib.rs
  • Update tests/test_bindings.py to remove deprecated methods, add smoke tests, and handle large integers
  • Refresh CI matrix and documentation (README.md, .github/workflows/CI.yml, Cargo.toml, jsonpath_rust_bindings.pyi)

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_bindings.py Replace find_non_empty, add smoke/overflow tests
src/lib.rs Switch to JpQuery/QueryRef, remove is_new_value
jsonpath_rust_bindings.pyi Remove is_new_value stub
README.md Remove is_new_value docs, add development steps
Cargo.toml Bump version & dependencies
.github/workflows/CI.yml Expand matrix, update maturin and caching settings
Comments suppressed due to low confidence (2)

tests/test_bindings.py:91

  • Replace prints in test_smoke_queries with actual assertions to verify each query returns expected results instead of relying on manual inspection.
print(f.find(query), '\n')

src/lib.rs:81

  • Using format!("{err:?}") may include extra debug formatting; consider err.to_string() for a cleaner, consistent error message.
Err(err) => Err(PyValueError::new_err(format!("{err:?}"))),

{'a': {'b': 'sample b'}}
```

## Development
Copy link

Copilot AI May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a step to run the test suite (e.g., pytest or cargo test) under the Development section so contributors can verify changes locally.

Copilot uses AI. Check for mistakes.

@night-crawler night-crawler merged commit 70d1d80 into main May 24, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant