Reproducer for a bug with format-preserving printer that loses parentheses around BooleanNot expressions #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maks-rafalko
changed the title
maks-rafalko
commented
Oct 18, 2025
| ----- | ||
| <?php | ||
|
|
||
| $a = !(a() && b()); |
There was a problem hiding this comment.
Fails with
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
'<?php
-$a = !(a() && b());'
+$a = !a() && b();'
|
PHP-Parser 5 uses a different way to handle operator precedence in the pretty printer, and it doesn't interact with formatting preservation properly :/ |
|
This looks pretty tricky. Previously responsibility for printing the parentheses was with the parent node, now it's with the child. Which only works properly if the child is printed without formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only a reproducer for the issue reported in #1119