Allow for relative, up to 5% differences, while comparing numerics for fieldmap correspondence #842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prime target is affines, but I am afraid ATM it would apply to anything numeric and thus potentially be not desired! Original use case triggering this is OpenNeuroDatasets/ds005256#2 .
Also looking back at when we added this, it was in bf9a3e1 and without due description -- we just switched from exact to
np.allclosewith its default ofrtol=1e-05, atol=1e-08, equal_nan=False.TODOs