-
Notifications
You must be signed in to change notification settings - Fork 17
ENH: Add transform analysis utils #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ENH: Add transform analysis utils #286
Conversation
|
I did not dare to create a I think the plotting should go to |
7fae796 to
73b27ba
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 96.74% 96.80% +0.06%
==========================================
Files 16 17 +1
Lines 1994 2034 +40
Branches 267 267
==========================================
+ Hits 1929 1969 +40
Misses 41 41
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
73b27ba to
86fa6af
Compare
|
Pinging @oesteban. |
86fa6af to
711146a
Compare
Yes
No, if you look at it closer, you'll see this is using apply_affine from nibabel.affines, which is not the same (that applies affines to points, our apply in nitransforms and the apply_affines (notice the 's' at the end) in nifreeze apply affines to images (internally to points, but that's not relevant here). |
oesteban
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I just realized of a little inconsistency. Other than that, I think this is almost ready.
|
Had a closer look at the |
04b0f77 to
8039887
Compare
Yes, nitransforms.resampling.apply does the job. We created the apply_transforms wrapper in nifreeze because the multiple-volume resampling was not very well supported in nitransforms, but that changed. |
825eb5f to
b71eac7
Compare
Add transform analysis utils. Transfer contents from the `NiFreeze` projects so that hey can be reused across projects requiring transform analysis: https://github.com/nipreps/nifreeze/blob/d27ba7552bbd9095c3c13b46443d87a4b5504c4c/src/nifreeze/analysis/motion.py https://github.com/nipreps/nifreeze/blob/d27ba7552bbd9095c3c13b46443d87a4b5504c4c/src/nifreeze/data/utils.py Add a fixture to be able to reuse a random number generator across tests. Co-authored-by: Oscar Esteban <code@oscaresteban.es>
b71eac7 to
f3236b7
Compare
Add transform analysis utils.
Transfer contents from the
NiFreezeprojects so that hey can be reused across projects requiring transform analysis:https://github.com/nipreps/nifreeze/blob/d27ba7552bbd9095c3c13b46443d87a4b5504c4c/src/nifreeze/analysis/motion.py https://github.com/nipreps/nifreeze/blob/d27ba7552bbd9095c3c13b46443d87a4b5504c4c/src/nifreeze/data/utils.py
Add a fixture to be able to reuse a random number generator across tests.
Fixes #239.