Skip to content

Fix Flutter web compilation: replace int64MaxValue with JavaScript-safe integer constant #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Flutter web compilation: replace int64MaxValue with JavaScript-safe integer constant #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d805ca
Initial plan
Copilot Nov 23, 2025
ec92e75
Replace int64MaxValue with web-safe JavaScript MAX_SAFE_INTEGER
Copilot Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/nitrite/lib/src/collection/operations/read_operations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'package:dart_numerics/dart_numerics.dart';
import 'package:nitrite/nitrite.dart';
import 'package:nitrite/src/collection/document_cursor.dart';
import 'package:nitrite/src/collection/operations/find_optimizer.dart';
Expand All @@ -10,6 +9,10 @@ import 'package:nitrite/src/common/stream/processed_document_stream.dart';
import 'package:nitrite/src/common/stream/sorted_document_stream.dart';
import 'package:rxdart/rxdart.dart';

/// Maximum safe integer value for JavaScript (2^53 - 1).
/// This is used instead of int64MaxValue to ensure compatibility with Flutter web.
const int _maxSafeInteger = 9007199254740991;

/// @nodoc
class ReadOperations {
final String _collectionName;
Expand Down Expand Up @@ -137,7 +140,7 @@ class ReadOperations {

if (findPlan.limit != null || findPlan.skip != null) {
rawStream = rawStream.skip(findPlan.skip ?? 0);
rawStream = rawStream.take(findPlan.limit ?? int64MaxValue);
rawStream = rawStream.take(findPlan.limit ?? _maxSafeInteger);
}
}

Expand Down
6 changes: 3 additions & 3 deletions packages/nitrite/test/collection/nitrite_id_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'package:dart_numerics/dart_numerics.dart' as num;
import 'package:nitrite/nitrite.dart';
import 'package:test/test.dart';

Expand All @@ -11,8 +10,9 @@ void main() async {
});

test('Test Limit', () {
var one = NitriteId.createId(num.int64MaxValue.toString());
var two = NitriteId.createId(num.int64MinValue.toString());
// Using max safe integer for JavaScript (2^53 - 1) to ensure web compatibility
var one = NitriteId.createId('9007199254740991');
var two = NitriteId.createId('-9007199254740991');
expect(one.compareTo(two), 1);
});

Expand Down