-
Notifications
You must be signed in to change notification settings - Fork 1
build(deps): bump esbuild, vite and @vitejs/plugin-vue #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bumps [esbuild](https://github.com/evanw/esbuild) to 0.25.6 and updates ancestor dependencies [esbuild](https://github.com/evanw/esbuild), [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) and [@vitejs/plugin-vue](https://github.com/vitejs/vite-plugin-vue/tree/HEAD/packages/plugin-vue). These dependencies need to be updated together. Updates `esbuild` from 0.18.20 to 0.25.6 - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG-2023.md) - [Commits](evanw/esbuild@v0.18.20...v0.25.6) Updates `vite` from 4.5.14 to 7.0.4 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.0.4/packages/vite) Updates `@vitejs/plugin-vue` from 4.6.2 to 6.0.0 - [Release notes](https://github.com/vitejs/vite-plugin-vue/releases) - [Changelog](https://github.com/vitejs/vite-plugin-vue/blob/main/packages/plugin-vue/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite-plugin-vue/commits/plugin-vue@6.0.0/packages/plugin-vue) --- updated-dependencies: - dependency-name: esbuild dependency-version: 0.25.6 dependency-type: indirect - dependency-name: vite dependency-version: 7.0.4 dependency-type: direct:development - dependency-name: "@vitejs/plugin-vue" dependency-version: 6.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
@claude review this MR |
|
Claude finished @nnegi88's task —— View job Dependency Update ReviewI've reviewed this dependency update PR that upgrades esbuild, vite, and @vitejs/plugin-vue to their latest versions. Todo List:
Changes Overview:This PR contains significant version updates for core build tools:
Project Context:
Breaking Changes Analysis:@vitejs/plugin-vue 6.0.0:
Vite 7.0.4:
esbuild 0.25.6:
Configuration Compatibility:vite.config.js:
CI/CD (GitHub Actions):
Review Recommendations:🔴 Action Required:
🟡 Monitor:
✅ Positive Aspects:
Recommended Next Steps:
Overall Assessment:✅ APPROVE with minor updates - This is a well-structured dependency update that brings security fixes and performance improvements. The main requirement is updating the Node.js version constraint to match the new dependency requirements. |
|
@claude do make the suggested changes |
|
Claude finished @nnegi88's task —— View job Changes Implementation Complete ✅I've successfully implemented the suggested changes from my previous review: Todo List:
Changes Made:
Note on Build Testing:I was unable to run the build test ( Summary:The main actionable change from my previous review has been implemented. The Node.js version requirement now matches the requirements of the updated dependencies, which should resolve the compatibility concerns I identified in the dependency update review. |
Update minimum Node.js version to match new dependency requirements from @vitejs/plugin-vue 6.0.0 and vite 7.0.4 Co-authored-by: Naveen Singh Negi <nnegi88@users.noreply.github.com>
Bumps esbuild to 0.25.6 and updates ancestor dependencies esbuild, vite and @vitejs/plugin-vue. These dependencies need to be updated together.
Updates
esbuildfrom 0.18.20 to 0.25.6Release notes
Sourced from esbuild's releases.
... (truncated)
Changelog
Sourced from esbuild's changelog.
... (truncated)
Commits
d38c1f0publish 0.25.6 to npm11e547emissing)in release notescc8ac0afix trailing comment whitespace1e3fb57fix #4178: add the--watch-delay=optionc1f5f18fix #4209: disable binary executable optimization on WASM platform (#4210)3ed5eccfix incorrect locations inCHANGELOG.md248089cfix #4224: allowtrystatements to become dead42f159copenharmony: keep makefile targets sorted63256e1chore: fix some comments (#4211)d803f72add support for openharmony-arm64 platform (#4212)Updates
vitefrom 4.5.14 to 7.0.4Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
8a65433release: v7.0.4324669cfix: allow resolving bare specifiers to relative paths for entries (#20379)5e29602build: remove@oxc-project/runtimedevDep (#20389)f562df8release: v7.0.338bb268chore: usen/prefer-node-protocolrule (#20368)45040d4chore(deps): update dependency dotenv to v17 (#20325)9465ae1fix(define): replace optional values (#20338)43ac73dfix(deps): update all non-major dependencies (#20366)31d1467fix(client): protect against window being defined but addEv undefined (#20359)5ab25e7chore(deps): update dependency rolldown to ^1.0.0-beta.24 (#20365)Updates
@vitejs/plugin-vuefrom 4.6.2 to 6.0.0Release notes
Sourced from
@vitejs/plugin-vue's releases.... (truncated)
Changelog
Sourced from
@vitejs/plugin-vue's changelog.... (truncated)
Commits
9c07818release: plugin-vue@6.0.0c7ddd62chore: remove Vite 7 beta from supported range (#598)98c52ebfix(deps): update all non-major dependencies (#609)5de85f6refactor: always usecrypto.hash(#606)67534e5fix(deps): update all non-major dependencies (#605)67ab76bchore: adddescriptionandkeywordsfield to package.json (#604)a495edfchore(deps): update dependency rollup to ^4.43.0 (#601)a4c32a8fix(deps): update all non-major dependencies (#600)256ac31chore(deps): update dependency rollup to ^4.41.1 (#591)43426c8fix(deps): update all non-major dependencies (#590)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.