doc: mention constructor comparison in assert.deepStrictEqual #60253
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `assert.deepStrictEqual` docs to explicitly mention that object constructors are included in the comparison. This clarifies behavior consistent with `util.isDeepStrictEqual` and helps prevent confusion when comparing derived objects or proxy instances.
nodejs-github-bot
added
assert
BridgeAR
requested changes
Oct 21, 2025
doc/api/assert.md
Outdated
| * [Type tags][Object.prototype.toString()] of objects should be the same. | ||
| * Only [enumerable "own" properties][] are considered. | ||
| * Object constructors are also compared to ensure that instances are strictly deep-equal. | ||
| This means that even if two objects share the same prototype and properties, differing constructors will result in inequality. |
There was a problem hiding this comment.
I do not think we should explain how things work and instead just explain what happens.
Suggested change
| This means that even if two objects share the same prototype and properties, differing constructors will result in inequality. |
doc/api/assert.md
Outdated
| both sides are {NaN}. | ||
| * [Type tags][Object.prototype.toString()] of objects should be the same. | ||
| * Only [enumerable "own" properties][] are considered. | ||
| * Object constructors are also compared to ensure that instances are strictly deep-equal. |
There was a problem hiding this comment.
This is actually not always true, e.g., for null prototypes, there is no constructor.
I am not sure how to word it appropriately right now.
There was a problem hiding this comment.
Thanks for the feedback @BridgeAR!
I’ve simplified the sentence to describe the behavior only, as suggested.
|
I do apologize
There are no bad intentions I just trying to do it and did not know how to
fix it 😔
Is there a way you out can help me please
Blanca c
El mar, 21 de oct de 2025, 10:43 a.m., Hamza ***@***.***>
escribió:
… ***@***.**** commented on this pull request.
------------------------------
In doc/api/assert.md
<#60253 (comment)>:
> @@ -399,6 +399,8 @@ are also recursively evaluated by the following rules.
both sides are {NaN}.
* [Type tags][Object.prototype.toString()] of objects should be the same.
* Only [enumerable "own" properties][] are considered.
+* Object constructors are also compared to ensure that instances are strictly deep-equal.
Thanks for the feedback @BridgeAR <https://github.com/BridgeAR>!
I’ve simplified the sentence to describe the behavior only, as suggested.
—
Reply to this email directly, view it on GitHub
<#60253 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIXDFWUV45WYZ7EQEOZIURL3YZWCNAVCNFSM6AAAAACJEQNED6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTGNRRHE3DKOBQG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
assert.deepStrictEqualdocs to explicitly mention that object constructors are included in the comparison. This clarifies behavior consistent withutil.isDeepStrictEqualand helps prevent confusion when comparing derived objects or proxy instances.