test: parallelize test-without-async-context-frame correctly #60273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It previously re-einvented the pattern matching that's already supported by test.py, and was running the tests one by one, which can lead to time out on slower machines. This move it to sequential and use wildcard support in test.py to correctly parallelize the tests.
nodejs-github-bot
added
needs-ci
|
On my macbook: $ tools/test.py test/sequential/test-without-async-context-frame.mjs
[00:00|% 100|+ 1|- 0]: Done
All tests passed.
$ git checkout main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
$ tools/test.py test/parallel/test-without-async-context-frame.mjs
[00:07|% 100|+ 1|- 0]: Done |
lpinca
approved these changes
Oct 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60273 +/- ##
=======================================
Coverage 88.57% 88.58%
=======================================
Files 704 704
Lines 208323 208323
Branches 40037 40043 +6
=======================================
+ Hits 184531 184537 +6
- Misses 15811 15815 +4
+ Partials 7981 7971 -10 🚀 New features to boost your workflow:
|
anonrig
approved these changes
Oct 16, 2025
joyeecheung
added
request-ci
atlowChemi
approved these changes
Oct 16, 2025
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 70c04c7 |
|
Oh, nice! Thanks for fixing this one. When I originally wrote that I had tried to allow it to run parallel, but the test itself was in the parallel set which seemed to overload the CI. I guess the solution I was missing was to just run the parallel set as a sequential test. Good catch! 🙂 |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2025
It previously re-einvented the pattern matching that's already supported by test.py, and was running the tests one by one, which can lead to time out on slower machines. This move it to sequential and use wildcard support in test.py to correctly parallelize the tests. PR-URL: #60273 Fixes: #60268 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It previously re-einvented the pattern matching that's already supported by test.py, and was running the tests one by one, which can lead to time out on slower machines.
This move it to sequential and use wildcard support in test.py to correctly parallelize the tests.
Fixes: #60268