Skip to content

doc: reserve NMV 145 for Electron 41 #61291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jan 7, 2026
Merged

doc: reserve NMV 145 for Electron 41 #61291

nodejs-github-bot merged 1 commit into from
Jan 7, 2026
+1 −0

Conversation

@nikwen
Copy link
Contributor

@nikwen nikwen commented Jan 5, 2026

Reserves NMV 145 for Electron 41. Thank you! 🙂

Relevant Electron task.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 5, 2026
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 5, 2026
@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2026
@nikwen
Copy link
Contributor Author

nikwen commented Jan 7, 2026

Thank you for all your reviews! Do I need to do anything else to get this merged?

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2026
@nodejs-github-bot nodejs-github-bot merged commit a18f8c1 into nodejs:main Jan 7, 2026
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 7, 2026

Landed in a18f8c1

@nikwen nikwen mentioned this pull request Jan 9, 2026
Merged
2 tasks
@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x. labels Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@aduh95 aduh95 aduh95 approved these changes

@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x PRs that should not land on the v25.x-staging branch and should not be released in v25.x.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@nikwen @nodejs-github-bot @lpinca @anonrig @cjihrig @tniessen @UlisesGascon @richardlau @aduh95 @avivkeller