Skip to content

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Jul 17, 2025

Description

closes #7909

I’m making changes quite quickly, so the code is not ready for review yet.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Jul 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Oct 6, 2025 4:33pm

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.59%. Comparing base (f3c9763) to head (4c2d6cb).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7991      +/-   ##
==========================================
+ Coverage   76.56%   76.59%   +0.02%     
==========================================
  Files         115      115              
  Lines        9610     9618       +8     
  Branches      323      323              
==========================================
+ Hits         7358     7367       +9     
+ Misses       2251     2250       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjohansebas
Copy link
Member Author

I’m reaching out to Kylie on Slack to get the logos of the missing companies, since I couldn’t find the brand kits for some of them or they require permission.

Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Caner Akdas <canerakdas@gmail.com>
@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Oct 2, 2025

this list of supporters seems to only be OC, not GH. We might get confusion about that
image

Unsure if both are accessible, but I suspect there are with more time and code

@canerakdas
Copy link
Member

this list of supporters seems to only be OC, not GH. We might get confusion about that image

Unsure if both are accessible, but I suspect there are with more time and code

Good point, GitHub Sponsors are not listing here yet, we’re waiting for them to be added with this issue;
#8199

To avoid confusion, I’m removing them from here for now; it makes more sense to re-add them once this issue is resolved.

@ovflowd
Copy link
Member

ovflowd commented Oct 2, 2025

@canerakdas not sure if Cloudflare Workers supports "node:crypto"? Hmm, might need to enable it via Wrangler config? https://developers.cloudflare.com/workers/runtime-apis/nodejs/crypto/

other elements of the codebase do the same thing
@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Oct 3, 2025

not sure if Cloudflare Workers supports "node:crypto"? Hmm, might need to enable it via Wrangler config?

my casual reading of those docs say that it should be fully supported. we only polyfill FS. for now I've tried something simple via 0cac120 - which matches our other usage anyways. build running now

edit: nope, same issue on playwright. still investigating

@ovflowd
Copy link
Member

ovflowd commented Oct 3, 2025

not sure if Cloudflare Workers supports "node:crypto"? Hmm, might need to enable it via Wrangler config?

my casual reading of those docs say that it should be fully supported. we only polyfill FS. for now I've tried something simple via 0cac120 - which matches our other usage anyways. build running now

edit: nope, same issue on playwright. still investigating

My understanding is that we need to enable the crypto feature on wrangler config file no? cc @dario-piotrowicz

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Oct 3, 2025

My understanding is that we need to enable the crypto feature on wrangler config file no?

From https://developers.cloudflare.com/workers/runtime-apis/nodejs/crypto/

All node:crypto APIs are fully supported in Workers with the following exceptions:

We have nodejs_compat already enabled there.

A closer look at this and copilot also suggests this might not be wrangler, but webpack within next ??


hidden as resolved Looking at this closer, I don't get why we are going to such extreme lengths for randomness. This isn't password generation or something critical, it displays some images on a website. 😅 . We can refactor this to simply use `Math.random`?

@ovflowd

This comment was marked as resolved.

Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Caner Akdas <canerakdas@gmail.com>
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@ovflowd ovflowd dismissed mcollina’s stale review October 6, 2025 17:32

Outdated review.

@ovflowd ovflowd merged commit b65f34c into main Oct 6, 2025
12 checks passed
@ovflowd ovflowd deleted the partner-pages branch October 6, 2025 17:32
@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Oct 6, 2025

BOOM! nice work everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dedicated Partners/Sponsors Page + Updates on the Home Page