-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore: partners/sponsors page #7991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7991 +/- ##
==========================================
+ Coverage 76.56% 76.59% +0.02%
==========================================
Files 115 115
Lines 9610 9618 +8
Branches 323 323
==========================================
+ Hits 7358 7367 +9
+ Misses 2251 2250 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
1efa109
to
81522ce
Compare
269d6aa
to
7e19b83
Compare
7e19b83
to
8724b52
Compare
8724b52
to
60f5bfa
Compare
60f5bfa
to
5960304
Compare
I’m reaching out to Kylie on Slack to get the logos of the missing companies, since I couldn’t find the brand kits for some of them or they require permission. |
5960304
to
545c769
Compare
545c769
to
77f675c
Compare
d22e42a
to
d45ec56
Compare
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Caner Akdas <canerakdas@gmail.com>
Good point, GitHub Sponsors are not listing here yet, we’re waiting for them to be added with this issue; To avoid confusion, I’m removing them from here for now; it makes more sense to re-add them once this issue is resolved. |
@canerakdas not sure if Cloudflare Workers supports "node:crypto"? Hmm, might need to enable it via Wrangler config? https://developers.cloudflare.com/workers/runtime-apis/nodejs/crypto/ |
other elements of the codebase do the same thing
my casual reading of those docs say that it should be fully supported. we only polyfill FS. for now I've tried something simple via 0cac120 - which matches our other usage anyways. build running now edit: nope, same issue on playwright. still investigating |
My understanding is that we need to enable the crypto feature on wrangler config file no? cc @dario-piotrowicz |
From https://developers.cloudflare.com/workers/runtime-apis/nodejs/crypto/
We have A closer look at this and copilot also suggests this might not be wrangler, but webpack within next ?? hidden as resolvedLooking at this closer, I don't get why we are going to such extreme lengths for randomness. This isn't password generation or something critical, it displays some images on a website. 😅 . We can refactor this to simply use `Math.random`? |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Caner Akdas <canerakdas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM!
BOOM! nice work everyone! |
Description
closes #7909
I’m making changes quite quickly, so the code is not ready for review yet.
Validation
Related Issues
Check List
pnpm format
to ensure the code follows the style guide.pnpm test
to check if all tests are passing.pnpm build
to check if the website builds without errors.