Skip to content

Conversation

@jorgenmk
Copy link
Contributor

Sample is using link_controller and needs to
use LTE_LC_PDN_* kconfigs.

Sample is using link_controller and needs to
use LTE_LC_PDN_* kconfigs.

Signed-off-by: Jorgen Kvalvaag <jorgen.kvalvaag@nordicsemi.no>
@jorgenmk jorgenmk requested a review from a team as a code owner November 28, 2025 13:22
Copilot AI review requested due to automatic review settings November 28, 2025 13:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Kconfig options in the HTTPS client sample to use the correct LTE link controller PDN configuration prefixes. The sample uses the link_controller library and should therefore use LTE_LC_PDN_* prefixed configuration options instead of the generic PDN_* options.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 28, 2025
@jtguggedal jtguggedal added bugfix Fixes a known bug and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 28, 2025
@jtguggedal jtguggedal added this to the 3.2.0 milestone Nov 28, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 28, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 9936c981ddb33f961854742b68f8ae99dcdd506f

more details

sdk-nrf:

PR head: 9936c981ddb33f961854742b68f8ae99dcdd506f
merge base: 2f953501a364ec71d3b1ef6e6fae418d8f3269f7
target head (main): 2f953501a364ec71d3b1ef6e6fae418d8f3269f7
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
samples
│  ├── net
│  │  ├── https_client
│  │  │  │ overlay-pdn-nrf91-ipv4.conf

Outputs:

Toolchain

Version: 43683a87ea
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:43683a87ea_5ea73affbf

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 10
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@jorgenmk jorgenmk merged commit 192d7a3 into nrfconnect:main Dec 1, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a known bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants