Skip to content

Conversation

@nonorze-VOXX
Copy link
Contributor

No description provided.

Copy link
Member

@NOOBDY NOOBDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be set by the user, ANSI escape codes can break output in environments that don't support colored outputs

@nonorze-VOXX
Copy link
Contributor Author

I think this should be set by the user, ANSI escape codes can break output in environments that don't support colored outputs

fixed

Copy link
Member

@NOOBDY NOOBDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users should probably pass in -DCMAKE_COLOR_DIAGNOSTICS=ON themselves when configuring

@ntut-rick ntut-rick added documentation Improvements or additions to documentation automation Build, Ship, CI/CD, Scripts, IDE things or Utility labels Feb 18, 2024
@nonorze-VOXX
Copy link
Contributor Author

Users should probably pass in -DCMAKE_COLOR_DIAGNOSTICS=ON themselves when configuring使用者在配置時可能應該傳入 -DCMAKE_COLOR_DIAGNOSTICS=ON 自己

auto have color not good?

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ntut-rick
Copy link
Member

auto have color not good?

depends on the user and their environment

@ntut-rick ntut-rick requested review from Dragonfly911117 and removed request for Error0229 February 20, 2024 17:25
Copy link
Member

@Dragonfly911117 Dragonfly911117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really use cmake with commands.

Copy link
Member

@ntut-rick ntut-rick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is the last one.

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
# set(CMAKE_COLOR_DIAGNOSTICS ON)
Copy link
Member

@ntut-rick ntut-rick Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary, don't touch @NOOBDY 's sacry CMakeLists.txt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wdym? Removing the line even if it's comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean i don't have anything to say

@ntut-rick ntut-rick marked this pull request as draft February 29, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Build, Ship, CI/CD, Scripts, IDE things or Utility documentation Improvements or additions to documentation

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

5 participants