Skip to content

Conversation

@HEKEPOIU
Copy link
Contributor

@HEKEPOIU HEKEPOIU commented Mar 2, 2024

Try to implemented display part of image.
I'm not sure this is needed?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@NOOBDY
Copy link
Member

NOOBDY commented Mar 2, 2024

I think if it is implemented as another Core::Drawable to keep Util::Image simple would be better

@HEKEPOIU
Copy link
Contributor Author

HEKEPOIU commented Mar 2, 2024

I think if it is implemented as another Core::Drawable to keep Util::Image simple would be better

How about inheritance from Util::Image?

@NOOBDY
Copy link
Member

NOOBDY commented Mar 2, 2024

not sure if inheritance is the best idea (it has backfired on me in most cases) but if you can make the API work as expected then sure
personally i would recommend using composition with Util::Image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@HEKEPOIU
Copy link
Contributor Author

HEKEPOIU commented Mar 2, 2024

like this?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@NOOBDY
Copy link
Member

NOOBDY commented Mar 3, 2024

I don't think include/Util/Image.hpp and src/Util/Image.cpp should be changed

@HEKEPOIU
Copy link
Contributor Author

HEKEPOIU commented Mar 3, 2024

I don't think include/Util/Image.hpp and src/Util/Image.cpp should be changed

mnn, ok, I will try other way.

@ntut-rick ntut-rick added the enhancement New feature or request label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: 🆕 Backlog

Development

Successfully merging this pull request may close these issues.

3 participants