Skip to content

Re-add supports for other build types. #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Re-add supports for other build types. #190

wants to merge 3 commits into from

Conversation

@Dragonfly911117
Copy link
Member

@Dragonfly911117 Dragonfly911117 commented May 5, 2024 •
edited
Loading

Related Issue(s)

Changes

  • During the build of Example with the Release build type, assets and optionally the config.json (with -DCOPY_PTSD_CONFIG=ON) will be copied to ${CMAKE_BINARY_DIR}.
  • Build types other than Debug and Release can be built with PTSD_ASSETS_DIR passed to CMake.

See also

Pull #3 from ptsd-template.

@Dragonfly911117 Dragonfly911117 added bug Something isn't working enhancement New feature or request labels May 5, 2024
@Dragonfly911117 Dragonfly911117 mentioned this pull request May 5, 2024
Open
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

NOOBDY
NOOBDY previously approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@NOOBDY NOOBDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iwomm but idk if it works Visual Studio (thanks M$FT)

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NOOBDY NOOBDY NOOBDY left review comments

@ntut-rick ntut-rick Awaiting requested review from ntut-rick

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request

Projects

New Game Framework
Status: 👀 In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CMake build type other than Debug

2 participants

@Dragonfly911117 @NOOBDY