-
Notifications
You must be signed in to change notification settings - Fork 23
Static image function member #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Static image function member #196
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk if this is really necessary but Util::Text probably needs the same change
I'll check and take back for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to merge upstream/main again. Both *GetMissingFontTextureSDLSurface() and *GetMissingImageTextureSDLSurface() have lost the Util namespace, leading to undefined references.
diff --git a/include/Util/MissingTexture.hpp b/include/Util/MissingTexture.hpp
index ea9e354..29ab966 100644
--- a/include/Util/MissingTexture.hpp
+++ b/include/Util/MissingTexture.hpp
@@ -21,9 +21,7 @@ static constexpr auto MISSING_IMAGE_TEXTURE_BASE64_DECODE =
DecodeBase64<MISSING_IMAGE_TEXTURE_BASE64_DECODE_LENGTH>(
MISSING_IMAGE_TEXTURE);
-namespace Util {
SDL_Surface *GetMissingFontTextureSDLSurface();
SDL_Surface *GetMissingImageTextureSDLSurface();
-} // namespace Util
#endifC:/Users/df/CLionProjects/PTSD/src/Util/Image.cpp:19: undefined reference to `GetMissingImageTextureSDLSurface()'
C:\Users\df\AppData\Local\Programs\CLion\bin\mingw\bin/ld.exe: libPTSD.a(Image.cpp.obj): in function `Util::Image::Image(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
C:/Users/df/CLionProjects/PTSD/src/Util/Image.cpp:45: undefined reference to `GetMissingImageTextureSDLSurface()'
C:\Users\df\AppData\Local\Programs\CLion\bin\mingw\bin/ld.exe: libPTSD.a(Text.cpp.obj): in function `Util::Text::Text(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, Util::Color const&)':
C:/Users/df/CLionProjects/PTSD/src/Util/Text.cpp:33: undefined reference to `GetMissingFontTextureSDLSurface()'
C:\Users\df\AppData\Local\Programs\CLion\bin\mingw\bin/ld.exe: libPTSD.a(Text.cpp.obj): in function `Util::Text::ApplyTexture()':
C:/Users/df/CLionProjects/PTSD/src/Util/Text.cpp:112: undefined reference to `GetMissingFontTextureSDLSurface()'
collect2.exe: error: ld returned 1 exit status```

Fix: #94