Cmake版本問題

[Du-Brandon]

Cmake4.1.0已不再支援SDL2的cmakelist(3.0.0)，因此我新增了一個判斷，若不符合則退版。

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[NOOBDY]

why does the diff look like this? is there something wrong w/ the linebreak or something?

[Du-Brandon]

why does the diff look like this? is there something wrong w/ the linebreak or something?

我今天使用CMAKE（version 4.1.0)建置時會出現錯誤，上面的提示是寫說4.1.0已不再支援3.5.0以下的cmake（SDL2的cmakelist 要求的版本是3.0.0），所以我新增了一個判斷是當版本為4.0.0以上時退版成3.5.0

[Dragonfly911117]

why does the diff look like this? is there something wrong w/ the linebreak or something?

我今天使用CMAKE（version 4.1.0)建置時會出現錯誤，上面的提示是寫說4.1.0已不再支援3.5.0以下的cmake（SDL2的cmakelist 要求的版本是3.0.0），所以我新增了一個判斷是當版本為4.0.0以上時退版成3.5.0

我覺得他指的是你的 CMakeLists.txt 的 diff 看起來有 tab/space 或 CRLF 問題

[Du-Brandon]

why does the diff look like this? is there something wrong w/ the linebreak or something?

我今天使用CMAKE（version 4.1.0)建置時會出現錯誤，上面的提示是寫說4.1.0已不再支援3.5.0以下的cmake（SDL2的cmakelist 要求的版本是3.0.0），所以我新增了一個判斷是當版本為4.0.0以上時退版成3.5.0

我覺得他指的是你的 CMakeLists.txt 的 diff 看起來有 tab/space 或 CRLF 問題

我回去確認一下，可能是編碼的問題。

[Dragonfly911117]

Please also address and fix the sussy diff issue.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[Du-Brandon]

我更正了大部分的錯誤，但換行導致的問題我無法解決

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[Dragonfly911117]

IWOMM.
CMake 4.1.1
GarudaLinux

[Copilot]

Pull Request Overview

This PR addresses a compatibility issue between CMake 4.1.0 and SDL2's CMakeLists (3.0.0) by adding version checks and policy configurations to ensure backward compatibility.

• Adds CMake version detection for versions 4.0 and above
• Sets policy CMP0000 to NEW for newer CMake versions
• Establishes minimum policy version to 3.5

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Wait, it doesn't seem like it was your script make it runnable. Taking a deep look, please hold on.

[Dragonfly911117]

why does the diff look like this? is there something wrong w/ the linebreak or something?

我今天使用CMAKE（version 4.1.0)建置時會出現錯誤，上面的提示是寫說4.1.0已不再支援3.5.0以下的cmake（SDL2的cmakelist 要求的版本是3.0.0），所以我新增了一個判斷是當版本為4.0.0以上時退版成3.5.0

可以請你提供 CMake 4.1.0 以上不再支援的文件或是你跑失敗的 Log 嗎？我這邊用 CMake 4.1.1 版本用 2866935 可以成功架好環境