Skip to content

Conversation

Muhammad-Altabba
Copy link

@Muhammad-Altabba Muhammad-Altabba commented Apr 15, 2025

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:
As part of: nucypher/taco-web#635, implement tests that generate session key test vectors to check the TS implementation agains them.
Also the README.md file has been updated.

Issues fixed/closed:

Notes for reviewers:
This PR is to be reviewed after merging #102, because it is based on its commits.

@Muhammad-Altabba Muhammad-Altabba changed the title Generate session key test vector Generate session key test vectors Apr 15, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 23.74%. Comparing base (5b531a4) to head (7d3edda).

Files with missing lines Patch % Lines
nucypher-core/src/dkg.rs 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   23.42%   23.74%   +0.32%     
==========================================
  Files          18       18              
  Lines        3475     3436      -39     
==========================================
+ Hits          814      816       +2     
+ Misses       2661     2620      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Muhammad-Altabba Muhammad-Altabba changed the title Generate session key test vectors [WIP] Generate session key test vectors Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants