Skip to content

fix: when OTA file version is negative number return N/A #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2025
Merged

fix: when OTA file version is negative number return N/A #2499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb771ce
feat: add a danger icon to OTA page for battery devices when battery …
May 6, 2025
b0affe4
style: run pretty
May 6, 2025
65ad564
fix: replace red circle danger icon with yellow triangle warning one
May 10, 2025
d7cdbd9
Merge branch 'nurikk:dev' into dev
Ricc68 May 10, 2025
04283c7
Merge branch 'nurikk:dev' into dev
Ricc68 Jun 7, 2025
0cf3c09
fix: when OTA file version is negative number return N/A
Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/ota-page/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ class OtaPage extends Component<PropsFromStore & OtaApi & WithTranslation<'ota'>
accessor: ({ state }) => {
const installed_version = ((state?.update ?? {}) as OTAState).installed_version;

if (typeof installed_version === 'number' && installed_version)
if (typeof installed_version === 'number' && installed_version >= 0)
return fileVersion2String(installed_version);
else return t('zigbee:firmware_installed_version_na');
},
Expand All @@ -199,7 +199,8 @@ class OtaPage extends Component<PropsFromStore & OtaApi & WithTranslation<'ota'>
accessor: ({ state }) => {
const latest_version = ((state?.update ?? {}) as OTAState).latest_version;

if (typeof latest_version === 'number' && latest_version) return fileVersion2String(latest_version);
if (typeof latest_version === 'number' && latest_version >= 0)
return fileVersion2String(latest_version);
else return 'N/A';
},
},
Expand Down
9 changes: 7 additions & 2 deletions ws-messages/onConnect.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8694,7 +8694,7 @@
"topic": "dining room/ac power/availability"
},
{
"payload": "offline",
"payload": "online",
"topic": "0x0017880103d55d65/availability"
},
{
Expand Down Expand Up @@ -8858,7 +8858,12 @@
"brightness": 110,
"color_mode": "xy",
"last_seen": "2022-04-15T17:48:30+08:00",
"state": "ON"
"state": "ON",
"update": {
"installed_version": -1,
"latest_version": -1,
"state": "unknown"
}
},
"topic": "0x0017880103d55d65"
}
Expand Down