Skip to content

Conversation

Nerivec
Copy link
Contributor

@Nerivec Nerivec commented Sep 24, 2025

These are apparently causing weird issues like Koenkk/zigbee2mqtt#28710
Seems the schema logic is not handling the multi-type well and defaulting or something along those lines.
I'm not able to replicate, must be a specific combo.

Since these settings can be set via onboarding, I figure might as well remove them from frontend since it's dangerous if it starts misbehaving.

@Koenkk I think that extra logic should be enough?

@Koenkk
Copy link
Collaborator

Koenkk commented Sep 24, 2025

Looks good! I agree it's better to hide as it might destroy networks, advanced users that want to change it can always change it in the configuration.yaml.

@maikeljacob
Copy link

These are apparently causing weird issues like Koenkk/zigbee2mqtt#28710 Seems the schema logic is not handling the multi-type well and defaulting or something along those lines. I'm not able to replicate, must be a specific combo.

Since these settings can be set via onboarding, I figure might as well remove them from frontend since it's dangerous if it starts misbehaving.

@Koenkk I think that extra logic should be enough?

I was changing settings on cache state/persist cache state/send cached state on startup

@Koenkk Koenkk merged commit 8a1b93c into nurikk:dev Sep 26, 2025
1 of 2 checks passed
@Koenkk
Copy link
Collaborator

Koenkk commented Sep 26, 2025

Thanks!

@Nerivec Nerivec deleted the remove-keys-from-settings branch September 26, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants