-
Notifications
You must be signed in to change notification settings - Fork 19
feat(oauth): gitlab support #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@TotomInc is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
e83bdf9 to
963a4e7
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Can someone from the core-team review this PR please? I believe all the changes required for GitLab provider support is done. I've done testing on our company's GitLab self-hosted repository, and it works well:
Thanks! 🙂 |
|
Thanks a lot @TotomInc! I've already had a check at it and it looks pretty good to me! There is a refactor I would like to do before merging, I'll take care of it, just need to finish another big refactor I'm working on first 😄 |
|
Alright awesome @larbish, feel free to ping me if necessary or if I can give some help in getting this merged 🙂 |
…e + create empty provider for dev mode
|
I did a small refactor:
Ready to merge once @farnabaz validate the auth behaviour ✅ |
Co-authored-by: Farnabaz <farnabaz@gmail.com>
commit: |
/auth/gitlab/__nuxt_studio/auth/gitlabwhich points to/server/routes/auth/gitlab.getruntime method/auth/adminto redirect to the proper provider as defined in the module configuseGitinto a shared composable, returns the proper git provider based on the module provider configGitProviderinterfacecreateGitLabProviderwith methods to fetch, commit and push to remote repositorycreateGitHubProviderwithGitProviderabstract interfacebase64, similar to GitHub providergitlabprovider in user & module configgitlab.applicationId,gitlab.applicationSecretandgitlab.instanceUrlmodule config properties with support for their own environment variablesbase64orutf-8)useGitProviderIconcomposable which returns the correct Git provider icon based on Studio user provider configSee #65 for context (fixes #65)
What's missing