Skip to content

fix(#3077): deleting a directory containing symlinked directory will delete the contents of the linked directory #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025
Merged

fix(#3077): deleting a directory containing symlinked directory will delete the contents of the linked directory #3168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3886617
fix(#3077) deleting a directory containing symlink file will delete a…
alexfinger21 Jul 22, 2025
1487cd9
fix(#3077): add diagnostic override TODO
alex-courtis Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lua/nvim-tree/actions/fs/remove-file.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,16 @@ local function remove_dir(cwd)

-- Type must come from fs_stat and not fs_scandir_next to maintain sshfs compatibility
local stat = vim.loop.fs_stat(new_cwd)
-- TODO remove once 0.12 is the minimum neovim version
-- path incorrectly specified as an integer, fixed upstream for neovim 0.12 https://github.com/neovim/neovim/pull/33872
---@diagnostic disable-next-line: param-type-mismatch
local lstat = vim.loop.fs_lstat(new_cwd)

local type = stat and stat.type or nil
-- Checks if file is a link file to ensure deletion of the symlink instead of the file it points to
local ltype = lstat and lstat.type or nil

if type == "directory" then
if type == "directory" and ltype ~= "link" then
local success = remove_dir(new_cwd)
if not success then
return false
Expand Down
Loading