ns-api: fix scraping bug when operator specifies custom node HTTP API port in bond #6093
+221
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
mmsinclair
force-pushed
the
bugfix/ns-api-node-custom-http-api-port
branch
from
983521f to
c6bf04b
Compare
mmsinclair
force-pushed
the
bugfix/ns-api-node-custom-http-api-port
branch
from
99196d5 to
fef7e42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that affects operators who run multiple nodes on a single IP address.
This change will mean that if an operator specifies a custom HTTP API port in their node bond, the Node Status API will only scrape this port for the self described API and no other port.
Previously, the Node Status API would fall back to default and common ports, in an effort to get self described information for operators with misconfigured nodes. This meant that when operators were running a custom HTTP API port and a default, any errors would result in the incorrect node data being scraped, because it would try the default and fall back ports.
We encourage operators to only run a single node per IP address to avoid situations like this.
This change is