Remove defaultProps #231
Open
Remove defaultProps #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roberto14
approved these changes
Feb 6, 2025
|
@mwildehahn Thanks for submitting this PR, and apologies for taking so long to get to it! Any idea whether this will cause the inverse to happen for older versions of React, i.e. will versions < 18 warn that cc @tizmagik |
|
Raised another PR #234 removing both defaultProps and prop-types. Can we prioritize on fixing this issue as it's a blocker for our react upgrade. Thanks. |
|
Bryan, I can no longer access this repo due to IP access restrictions on
NYT GitHub
…On Wed, May 7, 2025 at 8:58 PM Bryan Gergen ***@***.***> wrote:
*bgergen* left a comment (nytimes/react-tracking#231)
<#231 (comment)>
@mwildehahn <https://github.com/mwildehahn> Thanks for submitting this
PR, and apologies for taking so long to get to it! Any idea whether this
will cause the inverse to happen for older versions of React, i.e. will
versions < 18 warn that defaultProps are missing? I'm wondering whether
we should update the React peer dependency to just be ^18.0.0 (and maybe
remove the prop-types peer dep altogether).
cc @tizmagik <https://github.com/tizmagik>
—
Reply to this email directly, view it on GitHub
<#231 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB3XYESZOXA3MR6DWDHUPT25KT4FAVCNFSM6AAAAABRHKYM2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRRGAYTEOBXGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #230. I ran the react 19 codemod:
npx codemod react/19/replace-default-props --target srcwithin the repo.