Skip to content

Helm chart: Add "extraEnvVars" #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Helm chart: Add "extraEnvVars" #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
384ffbc
Add extraEnvVars to helm chart
jonerer Mar 4, 2022
6e16f99
Only render helm value kafka.properties if specified
jonerer Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ spec:
env:
- name: KAFKA_BROKERCONNECT
value: "{{ .Values.kafka.brokerConnect }}"
{{- if .Values.kafka.properties }}
- name: KAFKA_PROPERTIES
value: "{{ .Values.kafka.properties }}"
{{- end }}
- name: KAFKA_TRUSTSTORE
value: "{{ .Values.kafka.truststore }}"
- name: KAFKA_KEYSTORE
Expand All @@ -52,6 +54,9 @@ spec:
value: "{{ .Values.kafka.keystoreFile }}"
- name: SERVER_PORT
value: "{{ .Values.server.port }}"
{{- if .Values.extraEnvVars }}
{{- .Values.extraEnvVars | toYaml | nindent 10 }}
{{- end }}
- name: CMD_ARGS
{{- if .Values.mountProtoDesc.enabled }}
value: "--message.format=PROTOBUF --protobufdesc.directory=/protodesc/ {{ .Values.cmdArgs }}"
Expand Down
5 changes: 5 additions & 0 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
replicaCount: 1

## extraEnvVars:
## - name: FOO
## value: "bar"
extraEnvVars: []

image:
repository: obsidiandynamics/kafdrop
tag: latest
Expand Down