Skip to content

Fix learn-ocaml build -j 2 issue #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
erikmd wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix learn-ocaml build -j 2 issue #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31b5750
test: Add -j 2 in corpus tests
erikmd Sep 8, 2021
8698753
fix(Lwt_utils.mkdir_p): Surround the Lwt_unix.mkdir call with a Lwt.c…
erikmd Sep 8, 2021
e0e277d
Revert "fix(Lwt_utils.mkdir_p): Surround the Lwt_unix.mkdir call with…
erikmd Sep 8, 2021
e191f59
fix: some TOC/TOU race condition when running "learn-ocaml build -j 2"
erikmd Sep 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/repo/learnocaml_process_exercise_repository.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,8 @@ let main dest_dir =
Lwt_list.map_p,
spawn_grader
in
let static_dir = String.concat Filename.dir_sep [dest_dir; "static"] in
Lwt_utils.mkdir_p static_dir >>= fun () ->
listmap (fun (id, ex_dir, exercise, json_path, changed, dump_outputs,dump_reports) ->
let dst_ex_dir = String.concat Filename.dir_sep [dest_dir; "static"; id] in
Lwt_utils.mkdir_p dst_ex_dir >>= fun () ->
Expand Down
2 changes: 1 addition & 1 deletion tests/runtests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ do

if ! ( set -x; docker run --entrypoint '' \
-v "$(realpath "$corpus"):/repository" \
learn-ocaml /bin/sh -c "learn-ocaml --repo=/repository build" ); then
learn-ocaml /bin/sh -c "learn-ocaml --repo=/repository build -j 2" ); then
red "Failed to build $corpus"
exit 1
fi
Expand Down