feat: don't print entering/leaving directory message when no ouput #12974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
push-zrowwsototzk
branch
from
f0d32fc to
2e254ba
Compare
rgrinberg
reviewed
Dec 15, 2025
Alizter
force-pushed
the
push-zrowwsototzk
branch
from
2e254ba to
e2b4609
Compare
Alizter
commented
Dec 30, 2025
Alizter
force-pushed
the
push-zrowwsototzk
branch
from
e2b4609 to
557c454
Compare
rgrinberg
reviewed
Dec 30, 2025
Alizter
force-pushed
the
push-zrowwsototzk
branch
from
557c454 to
6657149
Compare
rgrinberg
reviewed
Dec 30, 2025
Alizter
force-pushed
the
push-zrowwsototzk
branch
from
6657149 to
2d7ba7a
Compare
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-zrowwsototzk
branch
from
2d7ba7a to
f58de00
Compare
rgrinberg
requested changes
Dec 30, 2025
Member
rgrinberg
left a comment
rgrinberg
left a comment
There was a problem hiding this comment.
Are there any tests where these messages are still being printed?
| | Entering_printed dir -> | ||
| (* make sure all buffered stdout output comes before the "leaving" message | ||
| or else it will interleave. *) | ||
| flush stdout; |
Member
There was a problem hiding this comment.
Can you move this refactoring (the moving of flush into finish) into a separate PR?
| flush stdout; | ||
| directory := Set dir; | ||
| M.print_user_message | ||
| (User_message.make [ Pp.verbatimf "Leaving directory '%s'" dir ]) |
Member
There was a problem hiding this comment.
The change from verbatim to verbatimf should also be a separate PR
Alizter
commented
Dec 30, 2025
Collaborator
Author
There was a problem hiding this comment.
@rgrinberg here you can observe how it prints when there is output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--display=quiethas no effect on--root-changing messages #12854